vault backup: 2024-10-04 10:25:25
This commit is contained in:
@@ -13,6 +13,7 @@ Positives:
|
|||||||
Concerns:
|
Concerns:
|
||||||
- [ ] Didn't appear to come super prepared with the solution in mind
|
- [ ] Didn't appear to come super prepared with the solution in mind
|
||||||
- [ ] I'm not 100% certain he read the specification in detail, but relied on his memory of how minesweeper worked
|
- [ ] I'm not 100% certain he read the specification in detail, but relied on his memory of how minesweeper worked
|
||||||
|
- [ ] Very minor: used different terms for the same thing `bombFound` but `MineBox`
|
||||||
|
|
||||||
Other comments:
|
Other comments:
|
||||||
- [ ] Created class for `MineBox` and `Board`
|
- [ ] Created class for `MineBox` and `Board`
|
||||||
@@ -27,3 +28,4 @@ Questions to ask:
|
|||||||
- [ ] Could you have Board "own" the rendering without it knowing exactly what it's renderings (strings, icons, HTML elements, etc)?
|
- [ ] Could you have Board "own" the rendering without it knowing exactly what it's renderings (strings, icons, HTML elements, etc)?
|
||||||
- [ ] Explain yoru choice to use `Convert.Int32`?
|
- [ ] Explain yoru choice to use `Convert.Int32`?
|
||||||
- [ ] You loop over the entire board or parts of the board (nested loops) a couple of times. How could you abstract that logic while still using it for different purposes?
|
- [ ] You loop over the entire board or parts of the board (nested loops) a couple of times. How could you abstract that logic while still using it for different purposes?
|
||||||
|
- [ ] Could you abstract the Game logic to untie it from the rendering and board?
|
||||||
Reference in New Issue
Block a user