From 4008df37c2b628c6e6f2e7bfbffebf9376d06c27 Mon Sep 17 00:00:00 2001 From: benjaminramey Date: Fri, 4 Oct 2024 10:25:25 -0500 Subject: [PATCH] vault backup: 2024-10-04 10:25:25 --- Jose De Jesus interview.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Jose De Jesus interview.md b/Jose De Jesus interview.md index 6406c61..6d1e13e 100644 --- a/Jose De Jesus interview.md +++ b/Jose De Jesus interview.md @@ -13,6 +13,7 @@ Positives: Concerns: - [ ] Didn't appear to come super prepared with the solution in mind - [ ] I'm not 100% certain he read the specification in detail, but relied on his memory of how minesweeper worked +- [ ] Very minor: used different terms for the same thing `bombFound` but `MineBox` Other comments: - [ ] Created class for `MineBox` and `Board` @@ -26,4 +27,5 @@ Questions to ask: - [ ] Why did you choose to have Program.cs "own" the rendering of the board instead of Board? - [ ] Could you have Board "own" the rendering without it knowing exactly what it's renderings (strings, icons, HTML elements, etc)? - [ ] Explain yoru choice to use `Convert.Int32`? -- [ ] You loop over the entire board or parts of the board (nested loops) a couple of times. How could you abstract that logic while still using it for different purposes? \ No newline at end of file +- [ ] You loop over the entire board or parts of the board (nested loops) a couple of times. How could you abstract that logic while still using it for different purposes? +- [ ] Could you abstract the Game logic to untie it from the rendering and board? \ No newline at end of file