benjaminramey/ObsidianJournal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vault backup: 2024-10-01 14:10:53

Browse Source
This commit is contained in:
Benjamin Ramey
2024-10-01 14:10:53 -05:00
parent 05945d5926
commit cabdd3ebfa
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Work/Edgar Munoz interview.md
View File

@@ -28,9 +28,9 @@ Nits:
2. Not communicating to user if flag cannot be placed because cell is revealed 2. Not communicating to user if flag cannot be placed because cell is revealed
3. Unnecessary comments 3. Unnecessary comments
Bad coding habits: Issues:
1. Reaching into the `Board` class to set cell properties directly in the `BoardGame` field instead of letting the `Board` class own manipulating the `BoardGame` 1. Reaching into the `Board` class to set cell properties directly in the `BoardGame` field instead of letting the `Board` class own manipulating the `BoardGame`
2. 2. Mixed logic of revealing the cell with "SearchNeighbors" method logic
Notes: Notes:
1. Using `Random` to fill 10 mines into the board, knows basics of `Random` API. 1. Using `Random` to fill 10 mines into the board, knows basics of `Random` API.
@@ -41,4 +41,5 @@ Notes:
6. He had thoughts about the `Board.BoardGame` field--renmaing it. This is a good sign to me, thinking about clearing naming something that's redundant (against the class name). 6. He had thoughts about the `Board.BoardGame` field--renmaing it. This is a good sign to me, thinking about clearing naming something that's redundant (against the class name).
7. Used a `Queue<T>` to do a breadth-first search of neighboring cells. 7. Used a `Queue<T>` to do a breadth-first search of neighboring cells.
8. Talked through logic of revealing 0-neighboring-mine-count cells well 8. Talked through logic of revealing 0-neighboring-mine-count cells well
9. Recognized duplicate logic of calculating neighboring cell coordinates and reused it