From cabdd3ebfa7d642ec9572332f9fa3c9b3f9d2a23 Mon Sep 17 00:00:00 2001 From: benjaminramey Date: Tue, 1 Oct 2024 14:10:53 -0500 Subject: [PATCH] vault backup: 2024-10-01 14:10:53 --- Work/Edgar Munoz interview.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Work/Edgar Munoz interview.md b/Work/Edgar Munoz interview.md index 35c8e53..ca47758 100644 --- a/Work/Edgar Munoz interview.md +++ b/Work/Edgar Munoz interview.md @@ -28,9 +28,9 @@ Nits: 2. Not communicating to user if flag cannot be placed because cell is revealed 3. Unnecessary comments -Bad coding habits: +Issues: 1. Reaching into the `Board` class to set cell properties directly in the `BoardGame` field instead of letting the `Board` class own manipulating the `BoardGame` -2. +2. Mixed logic of revealing the cell with "SearchNeighbors" method logic Notes: 1. Using `Random` to fill 10 mines into the board, knows basics of `Random` API. @@ -41,4 +41,5 @@ Notes: 6. He had thoughts about the `Board.BoardGame` field--renmaing it. This is a good sign to me, thinking about clearing naming something that's redundant (against the class name). 7. Used a `Queue` to do a breadth-first search of neighboring cells. 8. Talked through logic of revealing 0-neighboring-mine-count cells well +9. Recognized duplicate logic of calculating neighboring cell coordinates and reused it