benjaminramey/ObsidianJournal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vault backup: 2024-10-01 13:59:31

Browse Source
This commit is contained in:
Benjamin Ramey
2024-10-01 13:59:32 -05:00
parent fa32df3f9b
commit 9b9c3457b6
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Work/Edgar Munoz interview.md
View File

@@ -24,6 +24,12 @@ Questions:
Nits:
1. Property, field and variable naming not consistent
2. Not communicating to user if flag cannot be placed because cell is revealed
3. Unnecessary comments
Bad coding habits:
1. Reaching into the `Board` class to set cell properties directly in the `BoardGame` field instead of letting the `Board` class own manipulating the `BoardGame`
2.
Notes:
1. Using `Random` to fill 10 mines into the board, knows basics of `Random` API.
@@ -31,4 +37,5 @@ Notes:
3. Did not run the program early to see if there were errors
4. Found a bug he wrote in column and row check before executing program by thinking about it logically and visualizing the board.
5. Has a bug using `.Length` of a multi-dimensional array! Will be x * y and not x as he's hoping. He figured it out without any prompting from me and used `GridSize` in the check instead.
6. He had thoughts about the `Board.BoardGame` field--renmaing it. This is a good sign to me, thinking about clearing naming something that's redundant (against the class name).