From 9b9c3457b62ad73e1c1178eb71bb466a4ddd767c Mon Sep 17 00:00:00 2001 From: benjaminramey Date: Tue, 1 Oct 2024 13:59:32 -0500 Subject: [PATCH] vault backup: 2024-10-01 13:59:31 --- Work/Edgar Munoz interview.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Work/Edgar Munoz interview.md b/Work/Edgar Munoz interview.md index 06e6272..331067d 100644 --- a/Work/Edgar Munoz interview.md +++ b/Work/Edgar Munoz interview.md @@ -24,6 +24,12 @@ Questions: Nits: 1. Property, field and variable naming not consistent +2. Not communicating to user if flag cannot be placed because cell is revealed +3. Unnecessary comments + +Bad coding habits: +1. Reaching into the `Board` class to set cell properties directly in the `BoardGame` field instead of letting the `Board` class own manipulating the `BoardGame` +2. Notes: 1. Using `Random` to fill 10 mines into the board, knows basics of `Random` API. @@ -31,4 +37,5 @@ Notes: 3. Did not run the program early to see if there were errors 4. Found a bug he wrote in column and row check before executing program by thinking about it logically and visualizing the board. 5. Has a bug using `.Length` of a multi-dimensional array! Will be x * y and not x as he's hoping. He figured it out without any prompting from me and used `GridSize` in the check instead. +6. He had thoughts about the `Board.BoardGame` field--renmaing it. This is a good sign to me, thinking about clearing naming something that's redundant (against the class name).