1.5 KiB
1.5 KiB
To-dos
- Finish Skeletor asynification
- Review all uses of Url and HttpContext to make sure they are not used after we do ConfigureAwait(false) (like in private controller methods) Since all controller methods (private and public, or otherwise) have access to the controller's base class HttpContext and Url properties, I'm going to keep ConfigureAwait(true) for any controller methods but make sure they pass HttpContext down to any methods outside the controller
- Review all HttpContext.Current usage to replace with passed-in HttpContextBase parameters
- Follow-up on on-call action-item to handle liquid errors differently
- Search for specific causes of bad site performance on 11/1 FBOTM day https://faithlife.slack.com/archives/C03R1MQSR51/p1730821466045049?thread_ts=1730477236.809519&cid=C03R1MQSR51
- Consolidate broken circuit handling in Skeletor
- Give feedback to Ricardo on new.logos.com rollout ideas: Replatforming testing ideas - Google Docs
Summary
Kyle 1:1 - Analytics needs our help understanding and organizing our data
I ended up not liking the idea of a separate (even if just business hours) on-call rotation for martech to feed liquid errors to. I think this is simply the on-call dev's job to address or pass on these errors. The real fix is to implement the on-save liquid validation step that BEN has a case for.