1.4 KiB
1.4 KiB
To-dos
- Finish Skeletor asynification
- Review all uses of Url and HttpContext to make sure they are not used after we do ConfigureAwait(false) (like in private controller methods) Since all controller methods (private and public, or otherwise) have access to the controller's base class HttpContext and Url properties, I'm going to keep ConfigureAwait(true) for any controller methods but make sure they pass HttpContext down to any methods outside the controller
- Review all HttpContext.Current usage to replace with passed-in HttpContextBase parameters
- Search for specific causes of bad site performance on 11/1 FBOTM day https://faithlife.slack.com/archives/C03R1MQSR51/p1730821466045049?thread_ts=1730477236.809519&cid=C03R1MQSR51
Summary
I closed on my circuit-consolidation PR to put in a new one to reduce its scope to just cases where using ExecuteOrThrowOnBrokenCircuit is effectively a no-op. I excluded the less clear cases. This should get us a majority of the way there to consistent circuit usage.
Had a re-platform sync meeting with Kyle K. and several others. I'm still not convinced we are gaining anything by moving to Catalyst.
- The search is difficult to replicate correctly--especially if reuse the index we create from our code.
- Checkout appears to need further customization, it won't process $0 orders without requiring a payment method