benjaminramey/ObsidianJournal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vault backup: 2024-10-01 14:19:15

Browse Source
This commit is contained in:
Benjamin Ramey
2024-10-01 14:19:15 -05:00
parent cabdd3ebfa
commit eac602c9da
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Work/Edgar Munoz interview.md
View File

@@ -22,6 +22,7 @@ Questions:
6. Can he explain why using GridSize at the property initialization level doesn't work? He couldn't explain it--he needed a const or static integer for `GridSize` instead of a readonly class field. Opted to initialize the property at the top of the constructor.
7. Can he simplify the user input questions (like don't show option for placing a flag if no squares are revealed yet--ie, impossible to know where mine is yet), or does he want to allow a user to place flags without knowing
8. How can you communicate to the user better about what's going on (found mine or tried to place flag on revealed square, for example)?
9. What if someone enters a row or column that does not exist on the board?
Nits:
1. Property, field and variable naming not consistent
@@ -31,6 +32,7 @@ Nits:
Issues:
1. Reaching into the `Board` class to set cell properties directly in the `BoardGame` field instead of letting the `Board` class own manipulating the `BoardGame`
2. Mixed logic of revealing the cell with "SearchNeighbors" method logic
3. Somewhat spaghetti logic
Notes:
1. Using `Random` to fill 10 mines into the board, knows basics of `Random` API.