diff --git a/Work/Edgar Munoz interview.md b/Work/Edgar Munoz interview.md index 12c9de6..be072b1 100644 --- a/Work/Edgar Munoz interview.md +++ b/Work/Edgar Munoz interview.md @@ -11,16 +11,7 @@ Seems familiar with Visual Studio. Able to explain his basic plan to get going: Interesting choice: adding "NeighborCount" on the cell model--should the cell model know about its neighbors? IN progress: ahs not initialized the Board property yet--how will he discover this? - -Using `Random` to fill 10 mines into the board, knows basics of `Random` API. - -Why does each Cell need to know its neighbor count? They need to show a number, when revealed, of how many neighbors are mines. He renamed the property accordingly. - -Speaks English _very_ well. - -Found a bug he wrote in column and row check before executing program by thinking about it logically and visualizing the board. - -Has a bug using `.Length` of a multi-dimensional array! Will be x * y and not x as he's hoping. He figured it out without any prompting from me and used `GridSize` in the check instead. + Got NRE when he ran this. easily found that he missed initializing Questions: 1. Can you GridSize everywhere to avoid errors? @@ -31,5 +22,11 @@ Questions: Nits: 1. Property, field and variable naming not consistent -2. + +Notes: +1. Using `Random` to fill 10 mines into the board, knows basics of `Random` API. +2. Speaks English _very_ well +3. Did not run the program early to see if there were errors +4. Found a bug he wrote in column and row check before executing program by thinking about it logically and visualizing the board. +5. Has a bug using `.Length` of a multi-dimensional array! Will be x * y and not x as he's hoping. He figured it out without any prompting from me and used `GridSize` in the check instead.