From 3c3a388ef21164d34476863cd6ae0920cf625161 Mon Sep 17 00:00:00 2001 From: benjaminramey Date: Fri, 4 Oct 2024 10:21:52 -0500 Subject: [PATCH] vault backup: 2024-10-04 10:21:52 --- Jose De Jesus interview.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Jose De Jesus interview.md b/Jose De Jesus interview.md index 357d279..6406c61 100644 --- a/Jose De Jesus interview.md +++ b/Jose De Jesus interview.md @@ -8,6 +8,7 @@ Positives: - [ ] A user-facing thoughtful thing: he cleared the console at the top of each input loop - [ ] Used `StringBuilder` to render the board output, but decided against it later - [ ] Used string interpolation (newish C# capability) to render mine box content +- [ ] Excellent output message to user to give clear instructions on commands to input Concerns: - [ ] Didn't appear to come super prepared with the solution in mind @@ -18,8 +19,11 @@ Other comments: - [ ] Used multi-dimensional array of `MineBox`es in `Board` - [ ] Used `Random` to set mines randomly around the board - [ ] Used a while loop in Program until `bool gameEnded` was reached +- [ ] Used `Convert.ToInt32` instead of `int.Parse` to get coordinates from console input line Questions to ask: - [ ] What could you do to take your game logic and render it any way you wanted to (console, HTML, graphical...) - [ ] Why did you choose to have Program.cs "own" the rendering of the board instead of Board? -- [ ] Could you have Board "own" the rendering without it knowing exactly what it's renderings (strings, icons, HTML elements, etc)? \ No newline at end of file +- [ ] Could you have Board "own" the rendering without it knowing exactly what it's renderings (strings, icons, HTML elements, etc)? +- [ ] Explain yoru choice to use `Convert.Int32`? +- [ ] You loop over the entire board or parts of the board (nested loops) a couple of times. How could you abstract that logic while still using it for different purposes? \ No newline at end of file